Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

boards: m5stack: cores3: Add AW9523B configuration #82592

Merged
merged 1 commit into from
Dec 11, 2024

Conversation

soburi
Copy link
Member

@soburi soburi commented Dec 5, 2024

Adding AW9523B gpio expander configuration.

nordicjm
nordicjm previously approved these changes Dec 5, 2024
@soburi
Copy link
Member Author

soburi commented Dec 5, 2024

@sylvioalves @marekmatej

Could you please check this too?

@sylvioalves
Copy link
Collaborator

@soburi, I think the compatible you used isn't available in Zephyr. Perhaps you can add a new file at zephyr/dts/bindings/gpio/awinic,aw9523b-gpio.yaml with a similar content as in below:

# Copyright (c) ....
# SPDX-License-Identifier: Apache-2.0

description: AWINIC AW9523B GPIO Controller

compatible: "awinic,aw9523b-gpio"

include: gpio-controller.yaml

gpio-cells:
  - pin
  - flags

@kartben Can you confirm?

@soburi
Copy link
Member Author

soburi commented Dec 5, 2024

@sylvioalves

@soburi, I think the compatible you used isn't available in Zephyr. Perhaps you can add a new file at zephyr/dts/bindings/gpio/awinic,aw9523b-gpio.yaml with a similar content as in below:

The file has been added at just 6 hours before.

https://github.com/zephyrproject-rtos/zephyr/blob/main/dts/bindings/gpio/awinic%2Caw9523b-gpio.yaml

@sylvioalves
Copy link
Collaborator

@sylvioalves

@soburi, I think the compatible you used isn't available in Zephyr. Perhaps you can add a new file at zephyr/dts/bindings/gpio/awinic,aw9523b-gpio.yaml with a similar content as in below:

The file has been added at just 6 hours before.

https://github.com/zephyrproject-rtos/zephyr/blob/main/dts/bindings/gpio/awinic%2Caw9523b-gpio.yaml

Oh, really sorry. Thanks!

sylvioalves
sylvioalves previously approved these changes Dec 5, 2024
Adding AW9523B gpio expander configuration.

Signed-off-by: TOKITA Hiroshi <[email protected]>
@soburi soburi dismissed stale reviews from sylvioalves and nordicjm via 6a22f08 December 6, 2024 05:54
@soburi
Copy link
Member Author

soburi commented Dec 6, 2024

I rebased this to solve conflict.

@soburi
Copy link
Member Author

soburi commented Dec 10, 2024

@sylvioalves
Could you re-approve?

@kartben kartben merged commit 6642b1e into zephyrproject-rtos:main Dec 11, 2024
19 checks passed
@soburi soburi deleted the cores3_aw9523b branch December 11, 2024 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants